Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add hex version, move code to common #12074

Closed
wants to merge 1 commit into from

Conversation

mattip
Copy link
Member

@mattip mattip commented Oct 3, 2018

Add a hex version to version.py as well as caching it in C when first called. This is a step toward using the current NumPy version in PyUFuncObject, as requested in PR #11175.

The hex version is based on the PY_VERSION_HEX macro from CPython.

I also aggregated the other functions that deal with versions into common/npy_version.c

@charris
Copy link
Member

charris commented Oct 4, 2018

close/reopen for testing purposes.

@charris charris closed this Oct 4, 2018
@charris charris reopened this Oct 4, 2018
@charris charris closed this Oct 4, 2018
@charris charris reopened this Oct 4, 2018
@charris charris closed this Oct 5, 2018
@charris charris reopened this Oct 5, 2018
@mattip
Copy link
Member Author

mattip commented Oct 5, 2018

I don't understand the azure testing

  • I still see a [build in progress] for over 8 hours
  • For some reason the azure numpy.numpy-old pipeline is triggered for this PR

@charris
Copy link
Member

charris commented Oct 5, 2018

Yeah, somehow the test list has become cluttered in the process of experimentation. In this case, the tests seem to have completed in the stalled queue, which is the same as 'azure ci ...' and 'azure-pipeline...' but it didn't update. I suspect a timing glitch. Not sure why the old queue is still running, but suspect it is set up to respond. I'll delete it at some point now that I have figured out how to do that, but was a bit concerned that previous tests would be lost.

I think that azure doesn't archive old tests beyond 30 days or so, so that is something else we might want to look into.

@charris
Copy link
Member

charris commented Oct 5, 2018

Looks like newer PRs are just running just one pipeline, so I think this is just a glitch.

@charris
Copy link
Member

charris commented Oct 5, 2018

More experimentation.

@charris charris closed this Oct 5, 2018
@charris charris reopened this Oct 5, 2018
@charris
Copy link
Member

charris commented Oct 5, 2018

Can you try to rebase on master? The error on azure looks to be due to the old multithreaded testing.

@charris
Copy link
Member

charris commented Oct 5, 2018

I reran the mac test manually and it passed. I'm thinking that the numpy.numpy (1) problem is due to changing the name while a test was in progress.

@mattip
Copy link
Member Author

mattip commented Oct 5, 2018

Lets see if a rebase clears the in-progress build

@charris
Copy link
Member

charris commented Oct 5, 2018

If you hit the checks button, you can examine the test runs for the time. The only recent check is the azure-pipeline one.

@mattip
Copy link
Member Author

mattip commented Oct 7, 2018

The mailing list had one response which was positive and proposed to encode even more info. I left room for the extra information in the lower bits for a future PR to extend this one.

@mattip
Copy link
Member Author

mattip commented Oct 7, 2018

Not clear why the macos pipeline failed

@mattip
Copy link
Member Author

mattip commented Oct 10, 2018

The idea of caching the python module version in C met with a -1 on the mailing list, a different idea of creating a sys.version_info-like tuple in python seems to have more support. In #11175 we incremented NPY_API_VERSION and used that instead as it is more appropriate.

@mattip mattip closed this Oct 10, 2018
@mattip mattip deleted the numpy-hex-version branch March 4, 2019 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants