New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add hex version, move code to common #12074
Conversation
close/reopen for testing purposes. |
I don't understand the azure testing
|
Yeah, somehow the test list has become cluttered in the process of experimentation. In this case, the tests seem to have completed in the stalled queue, which is the same as 'azure ci ...' and 'azure-pipeline...' but it didn't update. I suspect a timing glitch. Not sure why the old queue is still running, but suspect it is set up to respond. I'll delete it at some point now that I have figured out how to do that, but was a bit concerned that previous tests would be lost. I think that azure doesn't archive old tests beyond 30 days or so, so that is something else we might want to look into. |
Looks like newer PRs are just running just one pipeline, so I think this is just a glitch. |
More experimentation. |
Can you try to rebase on master? The error on azure looks to be due to the old multithreaded testing. |
I reran the mac test manually and it passed. I'm thinking that the |
Lets see if a rebase clears the in-progress build |
If you hit the |
c75c9b2
to
1ccdf1d
Compare
The mailing list had one response which was positive and proposed to encode even more info. I left room for the extra information in the lower bits for a future PR to extend this one. |
1ccdf1d
to
5b7c9e8
Compare
Not clear why the macos pipeline failed |
The idea of caching the python module version in C met with a -1 on the mailing list, a different idea of creating a |
Add a hex version to
version.py
as well as caching it in C when first called. This is a step toward using the current NumPy version inPyUFuncObject
, as requested in PR #11175.The hex version is based on the
PY_VERSION_HEX
macro from CPython.I also aggregated the other functions that deal with versions into
common/npy_version.c